QPID-7972: [Broker-J] Put VirtualHostNode in ERRORed state if the underlying VirtualHost is

[overmeulen]

No description provided.

[adel-boutros]

Hello Olivier,

It seems you are mixing in your pull request 2 different issues: One related to the Error state of the virtualHost and the other one about problems with different locales (I assume tests are failing on your machine because it is configured with the FR locale).

In my opinion, it is better to split those into 2 different pull requests to have a better context

[k-wall]

Hello Olivier

Thanks for the contribution. It is much appreciated.

I am not too uncomfortable with the idea of special casing of the state behaviour for this one type of VirtualHostNode.

I think in the long term, in general parent objects should have some way to react to the state of the their child, but I think this would want to be done within the common mechanics of AbstractConfiguredObject rather than applied piecemeal. It would be useful to be able to apply different rules - for instance a virtualhost might be considered critical whereas a BrokerSyslogLogger not. This would be a larger piece of work.

I am looking for another way to solve your problem. Looking at BrokerImpl#performActivation, it currently checks the immediate decedents of the Broker if broker.failStartupWithErroredChild is set. We could alter this code so it can either check immediate descendants or the state of the entire tree. If the code had that ability would your use case by answered?

[overmeulen]

Hello,

Yes it would answer my use case. Actually I considered this option when doing the dev but I wasn't very fond of the Broker checking the whole tree of children nodes... I found it better to keep each node aware of just its direct children and it looked more correct to actually put the VirtualHostNode in ERRORed state too.

Olivier