QPID-8186 Use const ref when catching exceptions

apache · May 12, 2018 · 8b09d24 · 8b09d24
1 parent 706b5f3
commit 8b09d24
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/src/qpid/sys/posix/SocketAddress.cpp b/src/qpid/sys/posix/SocketAddress.cpp
@@ -205,11 +205,11 @@ bool SocketAddress::isComparable(const SocketAddress& hiPeer) const {
                 return false;
             }
             return true;
-        } catch (Exception) {
+        } catch (const Exception&) {
             // failed to resolve hi
             return false;
         }
-    } catch (Exception) {
+    } catch (const Exception&) {
         // failed to resolve lo
         return false;
     }

diff --git a/src/tests/AclHost.cpp b/src/tests/AclHost.cpp
@@ -39,14 +39,14 @@ QPID_AUTO_TEST_SUITE(AclHostTestSuite)
   try { \
     sys::SocketAddress sa("1.1.1.1", ""); \
     sa.firstAddress(); \
-} catch (qpid::Exception) { \
+} catch (const qpid::Exception&) { \
     haveIPv4 = false; \
 } \
   bool haveIPv6(true); \
   try { \
     sys::SocketAddress sa("::1", ""); \
     sa.firstAddress(); \
-} catch (qpid::Exception) { \
+} catch (const qpid::Exception&) { \
     haveIPv6 = false; \
 } \
 (void) haveIPv4; \