DISPATCH-476: Add support for groupId property for matching link routes and auto links #111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…es and auto links
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a proposed alternative for supporting a mapping of multiple connections - multiple link
routes/autolinks by grouping them on a 'groupId' identifier. The corresponding group is selected based on a connection property 'qd.route-container-group'.
We have discussed this approach previously, and somewhat decided that we should take a different approach. I wanted to implement this approach as a way of learning more of the router internals, so consider this PR a POC that you can close if you think this feature is not useful, though I do think it gives a lot of flexibility with little increase in complexity.