DISPATCH-557 - Moved management of connections from python agent to r… #125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ted-ross
requested changes
Dec 13, 2016
| @@ -23,6 +23,7 @@ | |||
| #include <qpid/dispatch/bitmask.h> | |||
| #include <qpid/dispatch/compose.h> | |||
| #include <qpid/dispatch/parse.h> | |||
| typedef struct qdr_core_t qdr_core_t; | |||
There was a problem hiding this comment.
Please move this back down with the other typedefs. You can add this line into router.h to solve the compilation issue.
| break; | ||
|
|
||
| case QDR_CONNECTION_SASL_MECHANISMS: | ||
| qd_compose_insert_string(body, conn->connection_info->sasl_mechanisms); |
There was a problem hiding this comment.
sasl_mechanisms is 0 if not specified. That causes a crash here (easily reproducible by starting the web console). If it's not present, this should insert a NULL into the body.
| bool is_authenticated, | ||
| bool opened, | ||
| char *sasl_mechanisms, | ||
| const char *dir, |
There was a problem hiding this comment.
There is an enumerated type for direction. You should use this rather than passing strings around.
| char *user; | ||
| bool is_authenticated; | ||
| bool opened; | ||
| const char *dir; |
There was a problem hiding this comment.
I think dir and role should use the enumerated types rather than arbitrary strings.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…outer core