Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump actions/upload-artifact from 3 to 4 #1677

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
22 changes: 11 additions & 11 deletions .github/workflows/build.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -145,7 +145,7 @@ jobs:
- name: Display ccache stats
run: ccache -s

# github actions/upload-artifact@v3 does not preserve executable permission on binaries
# github actions/upload-artifact@v4 does not preserve executable permission on binaries
- name: Compress build
working-directory: ${{github.workspace}}
run: >
Expand All @@ -161,7 +161,7 @@ jobs:
qpid-proton/build/python

- name: Upload archive
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
with:
name: qpid_dispatch_wrk_${{matrix.os}}_${{matrix.buildType}}_${{matrix.runtimeCheck}}_${{ matrix.protonGitRef }}
path: /tmp/archive.tar.xz
Expand Down Expand Up @@ -227,22 +227,22 @@ jobs:
ctest --timeout 1200 -C ${BuildType} -V -T Test --no-compress-output -I ${{matrix.shard}},,${{matrix.shards}} -j2 ${{env.DispatchCTestExtraArgs}}

- name: Upload test results
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
if: ${{ ! cancelled() }}
with:
name: Test_Results_${{matrix.os}}_${{matrix.buildType}}_${{matrix.runtimeCheck}}_${{matrix.protonGitRef}}_${{matrix.shard}}
path: ${{env.DispatchBuildDir}}/Testing/**/*.xml

- name: Upload log files (if any tests failed)
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
if: failure()
with:
name: testLogs_${{matrix.os}}_${{matrix.buildType}}_${{matrix.runtimeCheck}}_${{matrix.protonGitRef}}_${{matrix.shard}}
path: |
qpid-dispatch/build/tests

- name: Upload core files (if any)
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
if: failure()
with:
name: cores_${{matrix.os}}_${{matrix.buildType}}_${{matrix.runtimeCheck}}_${{matrix.protonGitRef}}_${{matrix.shard}}
Expand Down Expand Up @@ -464,22 +464,22 @@ jobs:
ctest --timeout 1200 -C ${BuildType} -V -T Test --output-on-failure --no-compress-output -I ${{matrix.shard}},,${{matrix.shards}} -j2 ${{env.DispatchCTestExtraArgs}}

- name: Upload test results
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
if: ${{ ! cancelled() }}
with:
name: Test_Results_${{matrix.container}}_${{matrix.buildType}}_${{matrix.runtimeCheck}}_${{matrix.protonGitRef}}_${{matrix.shard}}
path: ${{env.DispatchBuildDir}}/Testing/**/*.xml

- name: Upload log files (if any tests failed)
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
if: failure()
with:
name: testLogs_${{matrix.container}}_${{matrix.buildType}}_${{matrix.runtimeCheck}}_${{matrix.protonGitRef}}_${{matrix.shard}}
path: |
qpid-dispatch/build/tests

- name: Upload core files (if any)
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
if: failure()
with:
name: cores_${{matrix.container}}_${{matrix.buildType}}_${{matrix.runtimeCheck}}_${{matrix.protonGitRef}}_${{matrix.shard}}
Expand Down Expand Up @@ -579,13 +579,13 @@ jobs:
run: cmake --build "${DispatchBuildDir}" -t docs

- name: Store the rendered user-guide
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
with:
name: UserGuide
path: ${{env.DispatchBuildDir}}/docs/books/user-guide

- name: Store the rendered html man pages
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
with:
name: Manpages
path: ${{env.DispatchBuildDir}}/docs/man/*.html
Expand All @@ -594,7 +594,7 @@ jobs:
run: asciidoctor-pdf --failure-level INFO ${{github.workspace}}/docs/books/user-guide/book.adoc

- name: Store the rendered Dispatch book PDF
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
with:
name: book.pdf
path: ${{github.workspace}}/docs/books/user-guide/book.pdf
Expand Down