Crolke 918 vhost hostname #262
Conversation
|
This PR adds vhost attribute 'hostname' as the name of the entity. It deprecates vhost attribute 'id'. |
| @@ -1273,6 +1273,10 @@ | |||
| "type": "map", | |||
| "description": "A map where each key is a user group name and the value is a map of the corresponding settings for that group." | |||
| }, | |||
| "hostname": { | |||
There was a problem hiding this comment.
Could this use the deprecationName attribute from my earlier PR - https://github.com/apache/qpid-dispatch/pull/261/files#diff-981a10a2c9cab3708f003b402e7f8be4R1060
There was a problem hiding this comment.
Can't be used until you check it in...
| "hostname": { | ||
| "type": "string", | ||
| "description": "The vhost name." | ||
| }, |
There was a problem hiding this comment.
In PR 255, I updated the policy attribute descriptions (including "id") to be more descriptive. For the hostname description, you could use something like this:
The hostname of the vhost. This vhost policy will be applied to any client connection that is directed to the hostname that you specify.
|
Close this PR and create a new one using @ganeshmurthy deprecationName |
No description provided.