DISPATCH-1383: Policy tests hanging on some platforms - init race #534
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Policy tests have a subclass of FakeBroker. At the start of subclass init the code calls FakeBroker init. FakeBroker init starts a thread that runs the main loop. In the failing cases the FakeBroker main loop runs before the sublcasses complete their init functions. Then the main loop fails because class variables don't exist yet. The fix is to defer running FakeBroker init until the end of subclass init.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Policy tests have a subclass of FakeBroker.
At the start of subclass init the code calls FakeBroker init.
FakeBroker init starts a thread that runs the main loop.
In the failing cases the FakeBroker main loop runs before the
sublcasses complete their init functions. Then the main loop
fails because class variables don't exist yet.
The fix is to defer running FakeBroker init until the end of subclass init.