DISPATCH-1516 - Modified log statements to include link identifier. A… #645
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lso logged delivery outcome
kgiusti
reviewed
Dec 11, 2019
src/router_core/delivery.c
Outdated
| @@ -373,6 +376,8 @@ void qdr_delivery_increment_counters_CT(qdr_core_t *core, qdr_delivery_t *delive | |||
| core->modified_deliveries++; | |||
| } | |||
|
|
|||
| qd_log(core->log, QD_LOG_DEBUG, delivery->presettled?"Delivery outcome for pre-settled: dlv:%lx link:%"PRIu64" is %s": "Delivery outcome for: dlv:%lx link:%"PRIu64" is %s", (long) delivery, link->identity, pn_disposition_type_name(outcome)); | |||
There was a problem hiding this comment.
I had to read this a couple of times to figure out what's going on.
I'd avoid using a ?: to pick the format argument - that will work but it's.... clever.
Why not use a format string with a %s entry for the part of the output that varies, i.e.:
qd_log(..., ..., "Delivery outcome for%s: dlv:%lx link:<etc, etc, etc> is %s",
(delivery->presettled) ? " pre-settled" : "",
....)
Note the lack of space between "for" and the ":" in the format string and the leading space before "presettled"
…o select the format string
kgiusti
approved these changes
Dec 11, 2019
ChugR
pushed a commit
to ChugR/qpid-dispatch
that referenced
this pull request
Oct 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…lso logged delivery outcome