DISPATCH-1509: free core agent timer on shutdown #668
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| qdr_manage_response_t agent_response_handler; | ||
| qdr_subscription_t *agent_subscription_mobile; | ||
| qdr_subscription_t *agent_subscription_local; | ||
| qdr_agent_t *agent; |
There was a problem hiding this comment.
I wonder if this should be mgmt_agent instead of just agent because it is used to respond exclusively to management requests coming in on $management
| @@ -920,7 +913,9 @@ void *router_core_thread(void *arg); | |||
| uint64_t qdr_identifier(qdr_core_t* core); | |||
| void qdr_management_agent_on_message(void *context, qd_message_t *msg, int link_id, int cost, uint64_t in_conn_id); | |||
| void qdr_route_table_setup_CT(qdr_core_t *core); | |||
| void qdr_agent_setup_CT(qdr_core_t *core); | |||
| qdr_agent_t *qdr_agent(qdr_core_t *core); | |||
There was a problem hiding this comment.
Should this be called qdr_agent_CT instead?
There was a problem hiding this comment.
No - it's called before the core thread is running.
kgiusti
force-pushed
the
DISPATCH-1509
branch
from
6c2c30e
to
1d8c723
Compare
ganeshmurthy
approved these changes
Jan 20, 2020
Codecov Report
@@ Coverage Diff @@
## master #668 +/- ##
==========================================
+ Coverage 86.83% 86.89% +0.05%
==========================================
Files 92 92
Lines 21027 21046 +19
==========================================
+ Hits 18258 18287 +29
+ Misses 2769 2759 -10
Continue to review full report at Codecov.
|
ted-ross
approved these changes
Jan 21, 2020
Re-factor the management agent code by making the qdr_agent_t structure private and adding setup and teardown APIs.
kgiusti
force-pushed
the
DISPATCH-1509
branch
from
1d8c723
to
8d3d128
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactored the core agent code by pulling out the agent fields from qdr_core_t and putting them in their own private structure with setup/cleanup methods.