Save allocation of new promise on each writeAndFlush #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
franz1981
force-pushed
the
void_promise_write_and_flush
branch
from
430edd2
to
ce1db20
Compare
|
@tabish121 @gemmellr I have rebased it in order to make this PR compatible with the last version 👍 |
|
The main source of this optimization is coming from http://normanmaurer.me/presentations/2014-facebook-eng-netty/slides.html#8.0 |
|
I spent some time reviewing netty code and getting a handle on how this would change the current behavior. From what I can see this should be safe to apply. The tests all pass from a local checkout as well. I'd recommend creating a JIRA and updating the PR with the JIRA issue to link up the work done here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using a void promise on Netty writeAndFlush is possible to save
the allocation of a new one on each call.