RANGER-4225: Possible Jackson serialization issue due to not comply with Java bean standards

[sercanCyberVision]

What changes were proposed in this pull request?

@JsonProperty annotation has been added to model classes for mapping the properties with their corresponding getter/setter methods. This will not effect Ranger's functionality directly, but it will provide consistency in case there is Jackson jar conflict (or when/if Jackson is upgraded to version-2).
Please see the Jira for more detailed analysis of the issue https://issues.apache.org/jira/browse/RANGER-4225

Basically, some of the model classes do not comply with JavaBean naming conventions, therefore it is possible that Ranger may hit this issue https://stackoverflow.com/questions/30205006/why-does-jackson-2-not-recognize-the-first-capital-letter-if-the-leading-camel-c

As a reference of the issue, please see http://futuretask.blogspot.com/2005/01/java-tip-6-dont-capitalize-first-two.html

How was this patch tested?

Built the project and made sure that deserialized responses on UI side have correct property names even though Jackson-2 jars are in the classpath, hence the corresponding UI components work as expected.

[sercanCyberVision]

@kumaab could you please take a look at this?

[sercanCyberVision]

@mneethiraj could you please take a look at this? I hit this issue earlier, and the solution here can save some grief for the end-users for the future.

[bhavikpatel9977]

LGTM.

Kindly resolve the conflict.

[sercanCyberVision]

@bhavikpatel9977, thank you for reviewing the PR. I have resolved the conflict and quickly tested it again.
So, two actions have been taken here:

1. org.codehaus.jackson has been replaced with com.fasterxml.jackson.
2. @JsonProperty has been added to view classes to help jackson recognize java bean properties.

[bhavikpatel9977]

@mneethiraj Can you kindly review once

[mneethiraj]

@sercanCyberVision - thank you for taking up this critical update to switch to fasterxml.jackson. In addition to the couple of review comments, can you please verify that the final packaging does not include codehaus jackson library? It seems Ranger admin continues to use codehaus jackson library to serialize REST API responses. For example, the response includes fields having null and empty value.

[mneethiraj]

Consider using existing property fasterxml.jackson.version (line # 215) instead of introducing new one com.fasterxml.jackson.version. Also, update the version in #215 and #216 from 2.14.0 to 2.17.0.

[sercanCyberVision]

Thank you @mneethiraj for your review.

I have implemented above requested change and pushed it as a separate commit for now as it is easier for you to see the difference, the commit is cccbabf.

If needed, when we reach the final state, I can squash the commits or change the names.

[mneethiraj]

With the move to fasterxml.jackson 2.x, consider replacing deprecated include = JsonSerialize.Inclusion.NON_EMPTY, with @JsonInclude(JsonInclude.Include.NON_EMPTY)

[sercanCyberVision]

As stated above, the changes have been implemented with cccbabf commit.

[sercanCyberVision]

@sercanCyberVision - thank you for taking up this critical update to switch to fasterxml.jackson. In addition to the couple of review comments, can you please verify that the final packaging does not include codehaus jackson library? It seems Ranger admin continues to use codehaus jackson library to serialize REST API responses. For example, the response includes fields having null and empty value.

Thank you @mneethiraj for detailed review. You are right; codehaus.jackson was present in the admin library. I have checked the dependency tree and found that they were transitive. I have fixed the issue with this separate commit: 7eb06a5. If needed, we can squash it once the review is completed. I kept it separate so you can see the changes easily. The latest state is as follows:

ranger@ranger:/opt/ranger/ranger-3.0.0-SNAPSHOT-admin$ find . -name "*jackson*"
./ews/lib/jackson-core-2.17.0.jar
./ews/webapp/WEB-INF/lib/jackson-dataformat-smile-2.10.4.jar
./ews/webapp/WEB-INF/lib/jackson-dataformat-cbor-2.10.4.jar
./ews/webapp/WEB-INF/lib/jackson-databind-2.17.0.jar
./ews/webapp/WEB-INF/lib/jackson-core-2.17.0.jar
./ews/webapp/WEB-INF/lib/jackson-module-jaxb-annotations-2.17.0.jar
./ews/webapp/WEB-INF/lib/jackson-dataformat-yaml-2.10.4.jar
./ews/webapp/WEB-INF/lib/jackson-annotations-2.17.0.jar
./ews/webapp/WEB-INF/classes/ranger-plugins/knox/jackson-databind-2.17.0.jar
./ews/webapp/WEB-INF/classes/ranger-plugins/knox/jackson-core-2.17.0.jar
ranger@ranger:/opt/ranger/ranger-3.0.0-SNAPSHOT-admin$

I have one concern: when I deploy the project locally with Docker, I see the following issue on some endpoints after removing transitive dependencies:

However, I'm not sure if this is a real issue because when I saw the issue previously, others did not see it with the same codebase. For example, when I mentioned the issue here, in the next comment, the same codebase worked on another machine. Could you please check on your end?