RANGER-4783: remove duplicates for users/groups/roles during policy validation #311
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mneethiraj
reviewed
May 3, 2024
| return; | ||
| } | ||
| Iterator<String> itr = values.iterator(); | ||
| HashSet<String> uniqueElements = new HashSet<>(); |
There was a problem hiding this comment.
Consider replacing #965 to #975 with the following:
Set<String> uniqueElements = new HashSet<>();
for (Iterator<String> iter = values.iterator(); iter.hasNext(); ) {
if (!uniqueElements.add(iter.next())) {
iter.remove();
}
}
There was a problem hiding this comment.
Consider this version as well:
Set<String> uniqueElements = new HashSet<>();
values.removeIf(e -> !uniqueElements.add(e));
There was a problem hiding this comment.
Fixed in latest patch
mneethiraj
approved these changes
May 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
De-duplicate the users/groups/roles during policy validation when policy created/updated via REST (duplicates are prevented via ranger UI already)
How was this patch tested?
Local Docker container with master branch
Unzip the attached scripts folder - the folder contains some payloads which have duplicate users/groups/roles.
Run
bash create-policies.sh "/service/public/v2/api/policy"command and wait for the script to finishLogin to Ranger Admin and check policies created in Hive - duplicate users/groups/roles are de-duplicated.
scripts 3.zip