RATIS-2060 Avoid unexpected shutdown of RaftServerProxy during membership change #1069
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@szetszwo PTAL |
szetszwo
reviewed
Apr 24, 2024
There was a problem hiding this comment.
@OneSizeFitsQuorum , thanks for working on this! You are right that it should shutdown the division instead of the proxy.
Comment on lines
335
to
338
| server.close(); | ||
| return false; | ||
| case SHUTDOWN: | ||
| server.getRaftServer().close(); |
There was a problem hiding this comment.
Let change it for both case.
+++ b/ratis-server/src/main/java/org/apache/ratis/server/impl/LeaderElection.java
@@ -333,7 +333,7 @@ class LeaderElection implements Runnable {
return true;
case NOT_IN_CONF:
case SHUTDOWN:
- server.getRaftServer().close();
+ server.close();
server.getStateMachine().event().notifyServerShutdown(server.getRoleInfoProto());
return false;
case TIMEOUT:Signed-off-by: OneSizeFitQuorum <tanxinyu@apache.org>
SzyWilliam
approved these changes
Apr 25, 2024
There was a problem hiding this comment.
+1 the changes look good to me.
Thanks @OneSizeFitsQuorum for the patch!
Thanks @szetszwo for reviewing the patch!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see jira