RATIS-2093. Decouple metadata and configuration entries from appendEntries buffer for stateMachineCache' #1096
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tries buffer for stateMachineCache
duongkame
changed the title
|
@szetszwo can you have a look? |
szetszwo
reviewed
May 24, 2024
There was a problem hiding this comment.
@duongkame , thanks for working on this! Please see the comments inlined.
| ReferenceCountedObject.wrap(removedStateMachineData)); | ||
| } else { | ||
| cache.appendEntry(LogSegment.Op.WRITE_CACHE_WITH_STATE_MACHINE_CACHE, | ||
| ReferenceCountedObject.wrap(LogProtoUtils.copy(entry))); |
There was a problem hiding this comment.
It should copy removedStateMachineData instead.
| // The stateMachineData will be cached inside the StateMachine itself. | ||
| cache.appendEntry(LogSegment.Op.WRITE_CACHE_WITH_STATE_MACHINE_CACHE, | ||
| ReferenceCountedObject.wrap(removedStateMachineData)); | ||
| if ((removedStateMachineData != entry)) { |
There was a problem hiding this comment.
There are double parenthesis, i.e. ((...))
szetszwo
approved these changes
May 24, 2024
|
Thanks for merging it @szetszwo . Sorry, I have to ask for another favor, can release a snapshot version after this commit? |
|
@duongkame , deployed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
See RATIS-2093.
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/RATIS-2093
How was this patch tested?