RATIS-2096. Add a conf to enable/disable zero copy. #1099
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
szetszwo
reviewed
May 24, 2024
There was a problem hiding this comment.
@duongkame , thanks for working on this! Please see the comments inlined.
Sorry that I asked to remove the conf earlier!
| @@ -170,6 +172,10 @@ RaftPeerId getId() { | |||
|
|
|||
| ServerServiceDefinition bindServiceWithZeroCopy() { | |||
| ServerServiceDefinition orig = super.bindService(); | |||
| if (!zeroCopyEnabled) { | |||
| LOG.info("Zero copy is disabled."); | |||
There was a problem hiding this comment.
Print also the id:
LOG.info("{}: Zero copy is disabled.", getId());| @@ -241,6 +244,10 @@ RaftPeerId getId() { | |||
|
|
|||
| ServerServiceDefinition bindServiceWithZeroCopy() { | |||
| ServerServiceDefinition orig = super.bindService(); | |||
| if (!zeroCopyEnabled) { | |||
| LOG.info("Zero copy is disabled."); | |||
There was a problem hiding this comment.
Print also the id:
LOG.info("{}: Zero copy is disabled.", getId());
|
Thanks for the review @szetszwo . |
szetszwo
approved these changes
May 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Add a conf to enable/disable zero copy.
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/RATIS-2096
How was this patch tested?
CI.