RATIS-2112. Improve repeat-test workflow #1112
Conversation
adoroszlai
changed the title
There was a problem hiding this comment.
@adoroszlai , thanks for working on this! Just a minor comment inlined.
| @@ -65,6 +65,12 @@ for i in $(seq 1 ${ITERATIONS}); do | |||
| fi | |||
|
|
|||
| if [[ ${ITERATIONS} -gt 1 ]]; then | |||
| if ! grep -q "Running .*Test" "${REPORT_DIR}/output.log"; then | |||
There was a problem hiding this comment.
The pattern "Running .*Test" assume that the test name contains Test; e.g.
$grep "Running .*Test" ~/Downloads/result-3-9475609402-split-16/iteration4/output.log
[INFO] Running org.apache.hadoop.fs.ozone.TestHSync
It may be better to grep "Tests run: [1-9]".
$grep "Tests run: [1-9]" ~/Downloads/result-3-9475609402-split-16/iteration4/output.log
[ERROR] Tests run: 10, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 154.095 s <<< FAILURE! - in org.apache.hadoop.fs.ozone.TestHSync
[ERROR] Tests run: 10, Failures: 0, Errors: 1, Skipped: 0
Then, it will work for any test names.
There was a problem hiding this comment.
Thanks @szetszwo for the review.
Tests run: is not printed if there is a fork timeout (Ozone used to have a similar pattern before HDDS-10545).
[INFO] Running org.apache.hadoop.ozone.client.rpc.TestECKeyOutputStreamWithZeroCopy
[INFO]
[INFO] Results:
...
... There was a timeout or other error in the fork
While this workflow allows any test to be run, Ratis limits test naming by:
Lines 647 to 649 in dac27e4
There was a problem hiding this comment.
I see. Thanks for the info.
| @@ -65,6 +65,12 @@ for i in $(seq 1 ${ITERATIONS}); do | |||
| fi | |||
|
|
|||
| if [[ ${ITERATIONS} -gt 1 ]]; then | |||
| if ! grep -q "Running .*Test" "${REPORT_DIR}/output.log"; then | |||
There was a problem hiding this comment.
I see. Thanks for the info.
|
Thanks @szetszwo for the review. |
What changes were proposed in this pull request?
Improve
repeat-testworkflow:https://issues.apache.org/jira/browse/RATIS-2112
How was this patch tested?
repeat-testrun without failures:https://github.com/adoroszlai/ratis/actions/runs/9486024280
repeat-testrun with non-existent test class:https://github.com/adoroszlai/ratis/actions/runs/9486291646