RATIS-2121. Set javac --release when compiling with JDK 9+ #1119
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Java 9 introduced new
javac
option--release
, which helps ensure compatibility with the given Java version (blog with great explanation). The goal of this change is to set this option when compiling with JDK 9+, instead of--source
and--target
.--release
expects version without the old-style1.
prefix (i.e.8
instead of1.8
).maven-enforcer-plugin
added support for the same in version 3.2.1, so we also need to bump the plugin.https://issues.apache.org/jira/browse/RATIS-2121
How was this patch tested?
Compiled Ratis with JDK versions 8, 11, 17, targeting versions up to that of the JDK. Verified class file version.
CI:
https://github.com/adoroszlai/ratis/actions/runs/9722037600