Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RATIS-1602. Add a ProxiesPool inner class in NettyServerStreamRpc. #660

Merged
merged 1 commit into from Jul 4, 2022
Merged

RATIS-1602. Add a ProxiesPool inner class in NettyServerStreamRpc. #660

merged 1 commit into from Jul 4, 2022

Conversation

szetszwo
Copy link
Contributor

@szetszwo szetszwo changed the title RATIS-1602. Use try-with-resources to release DataStreamRequestByteBuf. RATIS-1602. Add a ProxiesPool inner class in NettyServerStreamRpc. Jun 30, 2022
@szetszwo
Copy link
Contributor Author

szetszwo commented Jul 2, 2022

@codings-dan , could you review this? Thank you in advance.

codings-dan
codings-dan approved these changes Jul 4, 2022
View reviewed changes
Copy link
Contributor

@codings-dan codings-dan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@szetszwo Thanks for working on this! LGTM +1

@codings-dan codings-dan merged commit 14e114c into apache:master Jul 4, 2022
szetszwo added a commit that referenced this pull request Jul 14, 2022
@szetszwo
RATIS-1602. Add a ProxiesPool inner class in NettyServerStreamRpc. (#660
fe0991a 
)
symious pushed a commit to symious/ratis that referenced this pull request Mar 5, 2024
@szetszwo @symious
RATIS-1602. Add a ProxiesPool inner class in NettyServerStreamRpc. (a…
bd38cb5 
…pache#660)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codings-dan codings-dan codings-dan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@szetszwo @codings-dan