Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RATIS-1620. Revert RATIS-1391 in branch 2.x #678

Closed
wants to merge 1 commit into from

Conversation

kaijchen
Copy link
Contributor

What changes were proposed in this pull request?

dropwizard.metrics is incompatible between 3.x and 4.x.
And we should not upgrade it in Ratis 2.x branch.

This reverts commit dbb4ffa.

What is the link to the Apache JIRA

https://issues.apache.org/jira/browse/RATIS-1620

How was this patch tested?

https://github.com/kaijchen/ratis/actions/runs/2647060883

@kaijchen
Copy link
Contributor Author

Cc @codings-dan

Copy link
Contributor

@codings-dan codings-dan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

branch-2 is a branch of the upcoming release 2.3.1, we plan to merge RATIS-1391 in 2.3.1, the current branch-2 still lacks two commit, see RATIS-1601 and RATIS-1614 . I will cherry-pick these commits later, so there may be no need to revert this commit. Thank you!

@kaijchen
Copy link
Contributor Author

Thanks for the explanation. I noticed this issue from the "Planning for 3.0.0" mail.

2.x.x have been around for more than a year. How about we start working on
3.0.0 so that we can have incompatible changes? One of the motivations is
to merge https://issues.apache.org/jira/browse/RATIS-1391 "Update library
dropwizard.metrics version to 4.x" since dropwizard.metrics is incompatible
between 3.x and 4.x.

Seems you've found a way to solve this issue, isn't it?

@codings-dan
Copy link
Contributor

@kaijchen In fact, I am not very familiar with this part. In my opinion, in order to prevent conflicts with application dependencies that depend on ratis, we shaded the dependency paths related to dropwizard in ratis, which seems to have solved the problem in the mail. Thank you!

@kaijchen
Copy link
Contributor Author

OK, closing this.

@kaijchen kaijchen closed this Jul 11, 2022
@szetszwo
Copy link
Contributor

Yes, we are using the shaded dropwizard.metrics now; see https://issues.apache.org/jira/browse/RATIS-1601 .

Just have merged it and other changes to branch-2.

@kaijchen kaijchen deleted the revert-1391 branch February 13, 2023 06:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants