Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RATIS-1776. Switch to slf4j-reload4j #814

Merged
merged 1 commit into from
Jan 22, 2023

Conversation

adoroszlai
Copy link
Contributor

What changes were proposed in this pull request?

Switch to slf4j-reload4j provider to avoid bundling log4j in Ratis distribution.

The reload4j project is a fork of Apache log4j version 1.2.17 with the goal of fixing pressing security issues. It is intended as a drop-in replacement for log4j version 1.2.17. By drop-in, we mean the replacement of log4j.jar with reload4j.jar in your build with no source code changes in .java files being necessary.

https://issues.apache.org/jira/browse/RATIS-1776

How was this patch tested?

Regular CI:
https://github.com/adoroszlai/incubator-ratis/actions/runs/3968298137/jobs/6801284615

@adoroszlai adoroszlai self-assigned this Jan 20, 2023
@adoroszlai adoroszlai added the dependencies Pull requests that update a dependency file label Jan 20, 2023
Copy link
Contributor

@szetszwo szetszwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 the change looks good.

@adoroszlai adoroszlai merged commit 0581577 into apache:master Jan 22, 2023
@adoroszlai
Copy link
Contributor Author

Thanks @szetszwo for the review.

@adoroszlai adoroszlai deleted the RATIS-1776_master branch January 22, 2023 10:23
symious pushed a commit to symious/ratis that referenced this pull request Mar 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
2 participants