Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RATIS-1841. Fixed bug where cluster restart failed to transfer snapshot. #879

Merged
merged 1 commit into from
May 13, 2023

Conversation

OneSizeFitsQuorum
Copy link
Contributor

@OneSizeFitsQuorum OneSizeFitsQuorum commented May 12, 2023

Signed-off-by: OneSizeFitQuorum <tanxinyu@apache.org>
@OneSizeFitsQuorum
Copy link
Contributor Author

@szetszwo PTAL

Copy link
Member

@SzyWilliam SzyWilliam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 LGTM

@szetszwo
Copy link
Contributor

@OneSizeFitsQuorum , RATIS-1838 is already resolved. Please file a new JIRA for this.

@OneSizeFitsQuorum OneSizeFitsQuorum changed the title RATIS-1838 Compare commit index with last included index when installSnapshot RATIS-1841 Fixed bug where cluster restart failed to transfer snapshot May 13, 2023
@OneSizeFitsQuorum
Copy link
Contributor Author

@OneSizeFitsQuorum , RATIS-1838 is already resolved. Please file a new JIRA for this.

Thank you for reminding me. I have created an issue~

@szetszwo szetszwo changed the title RATIS-1841 Fixed bug where cluster restart failed to transfer snapshot RATIS-1841. Fixed bug where cluster restart failed to transfer snapshot. May 13, 2023
Copy link
Contributor

@szetszwo szetszwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 the change looks good.

@szetszwo szetszwo merged commit f82f302 into apache:master May 13, 2023
@szetszwo
Copy link
Contributor

@OneSizeFitsQuorum , thanks a lot for working on this!

@SzyWilliam , thanks for reviewing this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants