Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RATIS-1959. Omit download progress in CI builds #982

Merged
merged 1 commit into from
Dec 10, 2023

Conversation

adoroszlai
Copy link
Contributor

What changes were proposed in this pull request?

If dependencies are not available in local repo, Maven logs download progress for each:

[INFO] Downloading from apache.snapshots: https://repository.apache.org/snapshots/com/github/spotbugs/spotbugs-maven-plugin/4.2.0/spotbugs-maven-plugin-4.2.0.pom
[INFO] Downloading from central: https://repo.maven.apache.org/maven2/com/github/spotbugs/spotbugs-maven-plugin/4.2.0/spotbugs-maven-plugin-4.2.0.pom
[INFO] Downloaded from central: https://repo.maven.apache.org/maven2/com/github/spotbugs/spotbugs-maven-plugin/4.2.0/spotbugs-maven-plugin-4.2.0.pom (33 kB at 1.3 MB/s)
[INFO] Downloading from apache.snapshots: https://repository.apache.org/snapshots/com/github/hazendaz/base-parent/27/base-parent-27.pom
[INFO] Downloading from central: https://repo.maven.apache.org/maven2/com/github/hazendaz/base-parent/27/base-parent-27.pom
[INFO] Downloaded from central: https://repo.maven.apache.org/maven2/com/github/hazendaz/base-parent/27/base-parent-27.pom (87 kB at 7.9 MB/s)

https://github.com/apache/ratis/actions/runs/7074176463/job/19254929774#step:5:49

This may unnecessarily increase log by more than 1000 lines currently (from ~1800 to ~3000).

CI uses Github Actions cache for Maven dependencies, so this is only noticeable in case of cache miss (usually on POM change or in forks).

https://issues.apache.org/jira/browse/RATIS-1959

How was this patch tested?

CI build in fork with cache miss:

Cache not found for input keys: maven-repo-edc44bba0b03b489af4e8788b210a64e0b74f4870fe3570470bb3a34fc6ece76-build, maven-repo-edc44bba0b03b489af4e8788b210a64e0b74f4870fe3570470bb3a34fc6ece76, maven-repo-

https://github.com/adoroszlai/ratis/actions/runs/7149655412/job/19472089995#step:3:12

but build output only ~1800 lines:

https://github.com/adoroszlai/ratis/actions/runs/7149655412/job/19472089995#step:5:1806

@adoroszlai adoroszlai self-assigned this Dec 9, 2023
Copy link
Contributor

@szetszwo szetszwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 the change looks good.

@szetszwo szetszwo merged commit 01b386b into apache:master Dec 10, 2023
10 checks passed
@adoroszlai adoroszlai deleted the RATIS-1959 branch December 10, 2023 07:59
@adoroszlai
Copy link
Contributor Author

Thansk @szetszwo for reviewing and merging this.

symious pushed a commit to symious/ratis that referenced this pull request Apr 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants