Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace boost log with spdlog #185

Closed
wants to merge 16 commits into from
Closed

replace boost log with spdlog #185

wants to merge 16 commits into from

Conversation

apppur
Copy link

@apppur apppur commented Sep 17, 2019

What is the purpose of the change

replace boost log with spdlog

Brief changelog

replace boost log with spdlog

Verifying this change

replace boost log with spdlog

Follow this checklist to help us incorporate your contribution quickly and easily. Notice, it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR.

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when a cross-module dependency exists.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

@apppur apppur changed the title Logs replace boost log with spdlog Sep 17, 2019
@apppur apppur changed the title replace boost log with spdlog replace boost log with spdlog, use this PR to replace https://github.com/apache/rocketmq-client-cpp/pull/163 Sep 17, 2019
Copy link
Contributor

@ifplusor ifplusor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please rebase all commits on the latest commit on apache/master, and squash they into single commit. See https://git-scm.com/book/en/v2/Git-Tools-Rewriting-History

src/common/UtilAll.h Outdated Show resolved Hide resolved
src/common/UtilAll.cpp Outdated Show resolved Hide resolved
src/common/UtilAll.cpp Outdated Show resolved Hide resolved
src/common/UtilAll.cpp Outdated Show resolved Hide resolved
@ShannonDing ShannonDing added the enhancement New feature or request label Jan 10, 2020
@vongosling vongosling changed the title replace boost log with spdlog, use this PR to replace https://github.com/apache/rocketmq-client-cpp/pull/163 replace boost log with spdlog Feb 17, 2020
@ifplusor
Copy link
Contributor

ifplusor commented Jul 2, 2020

Already done in the re_dev branch.

@ifplusor ifplusor closed this Jul 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants