New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
replace boost log with spdlog #185
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apppur
changed the title
replace boost log with spdlog
replace boost log with spdlog, use this PR to replace https://github.com/apache/rocketmq-client-cpp/pull/163
Sep 17, 2019
ifplusor
requested changes
Sep 18, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please rebase all commits on the latest commit on apache/master, and squash they into single commit. See https://git-scm.com/book/en/v2/Git-Tools-Rewriting-History
modify %x -> %p revert SIZET_FMT macro replace the magic number with a macro
ifplusor
requested changes
Sep 19, 2019
ifplusor
reviewed
Sep 19, 2019
vongosling
changed the title
replace boost log with spdlog, use this PR to replace https://github.com/apache/rocketmq-client-cpp/pull/163
replace boost log with spdlog
Feb 17, 2020
Already done in the re_dev branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
replace boost log with spdlog
Brief changelog
replace boost log with spdlog
Verifying this change
replace boost log with spdlog
Follow this checklist to help us incorporate your contribution quickly and easily. Notice,
it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR
.[ISSUE #123] Fix UnknownException when host config not exist
. Each commit in the pull request should have a meaningful subject line and body.