Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Internal package in go #184

Closed
ofttryaj opened this issue Sep 2, 2019 · 5 comments
Closed

Internal package in go #184

ofttryaj opened this issue Sep 2, 2019 · 5 comments
Labels
bug Something isn't working
Milestone
Native-2.0.0-alpha3

Comments

@ofttryaj
Copy link

ofttryaj commented Sep 2, 2019

When I use rocketmq-client-go internal package, go will complain that use of internal package github.com/apache/rockemq-client-go/internal/utils not allowed
@wenfengwang
Copy link
Member

What's scenario you want to use internal/utils? in common, the internal should not be used by external.

@ofttryaj
Copy link
Author

ofttryaj commented Sep 2, 2019

examples/consumer/pull/main.go, this example use the github.com/apache/rockemq-client-go/internal/utils at line 49

@wenfengwang
Copy link
Member

@ofttryaj it's our mistake, we will fix it

@ShannonDing ShannonDing added the bug Something isn't working label Sep 5, 2019
@ShannonDing ShannonDing added this to the Native-2.0.0-alpha3 milestone Sep 5, 2019
@wenfengwang
Copy link
Member

fixed at #199

ShannonDing pushed a commit that referenced this issue Sep 10, 2019
@wenfengwang @ShannonDing
[ISSUE #184]Fix errors of using internal codes in the exported snippet
303ae26
@ShannonDing
Copy link
Member

close due to #199

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
Native-2.0.0-alpha3
Development

No branches or pull requests
3 participants
@wenfengwang @ofttryaj @ShannonDing