Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Trace] [Enhancement] Add ClientHost and GroupName to tracebean #585

Closed
maixiaohai opened this issue Jan 5, 2021 · 0 comments · Fixed by #586
Closed

[Trace] [Enhancement] Add ClientHost and GroupName to tracebean #585

maixiaohai opened this issue Jan 5, 2021 · 0 comments · Fixed by #586
Labels
discuss Something undering disscussing enhancement New feature or request

Comments

@maixiaohai
Copy link
Contributor

  1. Please describe the issue you observed:

    • What did you do (The steps to reproduce)?
      I used trace example to produce and consume messages.
    • What did you expect to see?
      Check the message trace on console and find the correct storeHost and groupName
    • What did you see instead?
      The response as follows , the storeHost is the console host, not the client host; the groupName in SubAfter message is empty
    "status":0,
    "data":[
        {
            "msgId":"0AE830DD4A4F0000000011b799480001",
            "tags":"",
            "keys":"null",
            "storeHost":"xxx",
            "costTime":0,
            "msgType":"SubBefore",
            "offSetMsgId":"",
            "timeStamp":1609754334084,
            "topic":"",
            "groupName":"zx_tst",
            "status":"Sucess"
        },
        {
            "msgId":"0AE830DD4A4F0000000011b799480001",
            "tags":"",
            "keys":"null",
            "storeHost":"xxx",
            "costTime":0,
            "msgType":"SubAfter",
            "offSetMsgId":"",
            "timeStamp":1609755807542,
            "topic":"",
            "groupName":"",
            "status":"Sucess"
        }
    ],
    "errMsg":null
} 
  1. Please tell us about your environment:

    • What is your OS?

    • What is your client version?
      2.1.0

    • What is your RocketMQ version?
      4.7.0

  2. Other information (e.g. detailed explanation, logs, related issues, suggestions on how to fix, etc):
    When rmq broker update to version 4.8.0, the added trace message filed will be decoded and show up.
    The console version is 2.0.

@ShannonDing ShannonDing added discuss Something undering disscussing enhancement New feature or request labels Jan 15, 2021
maixiaohai added a commit that referenced this issue Jun 17, 2021
… message (#586)

* Add more trace field

* fix test failure

* Fix go fmt can not pass

Co-authored-by: zhangxu16 <zhangxu16@xiaomi.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discuss Something undering disscussing enhancement New feature or request
Projects
None yet
2 participants