Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2.0.0-alpha1: Produce message success but missing tag and properties. #65

Closed
easyforgood opened this issue Jun 5, 2019 · 5 comments
Closed

Comments

@easyforgood
Copy link

easyforgood commented Jun 5, 2019

BUG REPORT

  1. Please describe the issue you observed:
  • What did you do (The steps to reproduce)?

Here is my code, it's a producer:

	_msg := kernel.NewMessage(cli.opts.pTopic, body)
	_msg.PutProperty(kernel.PropertyTags, "test_tag")
	_msg.PutProperty("user_defined_key", "hi")
	result, err := cli.p.SendSync(context.Background(), _msg)

	zap.S().Infow("RMQ message", "msg", _msg.String())
	zap.S().Infow("Send Result", "result", result)
  • What did you expect to see?

Tag and Property should be shown in RocketMQ Dashboard.

  • What did you see instead?

There is not.

Here is my log:
image

Here is RocketMQ Dashboard:
image

  1. Please tell us about your environment:

    • What is your OS?
      OSX 10.14.4

    • What is your client version?
      2.0.0-alpha1

    • What is your RocketMQ version?
      Sorry, I dont know

  2. Other information (e.g. detailed explanation, logs, related issues, suggestions on how to fix, etc):

I notice that ./kernel/request.go, there's no properties in SendRequest.Encode(), So I fixed it as follow:

Snipaste_2019-06-05_08-50-44

But It still did not work.

So Maybe the whole rmq message header encode has problem.

@wenfengwang
Copy link
Member

Thank you @easyforgood , we will fix it in next release

@wenfengwang wenfengwang mentioned this issue Jun 27, 2019
20 tasks
xujianhai666 added a commit to xujianhai666/rocketmq-client-go that referenced this issue Jul 6, 2019
zongtanghu pushed a commit that referenced this issue Jul 7, 2019
* fix message properties. fix #65

* simplify commit

* simplify commit
zongtanghu pushed a commit that referenced this issue Jul 8, 2019
* fix message properties. fix #65

* simplify commit

* simplify commit

* Support multiple NameServer. fix #95

* add retry on queryTopicRouteInfoFromServer

* move pkg to kernel
@xujianhai666
Copy link
Member

@easyforgood Hi, we have fix the bug, can u check and close the ISSUE?

@easyforgood
Copy link
Author

@xujianhai666 Thanks for your bugfix. I'm looking forward to trying it in the coming release tag, 2.0.0-alpha2.

@wenfengwang
Copy link
Member

@ShannonDing please close the issue

@wenfengwang
Copy link
Member

The 2.0.0-alpha2 is preparing to release, the release note: #121. and can download in page: https://github.com/apache/rocketmq-client-go/releases

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants