Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support standard json format when update route from nameserver #845

Closed
yuz10 opened this issue Jun 16, 2022 · 1 comment · Fixed by #846
Closed

support standard json format when update route from nameserver #845

yuz10 opened this issue Jun 16, 2022 · 1 comment · Fixed by #846
Labels
discuss Something undering disscussing

Comments

@yuz10
Copy link
Member

yuz10 commented Jun 16, 2022

BUG REPORT

  1. Please describe the issue you observed:

    • What did you do (The steps to reproduce)?
      update nameserver version to 4.9.4-snapshot (develop branch)
      and use go client to produce message

    • What did you expect to see?
      produce message success

    • What did you see instead?
      produce message fail
      because Let name server generate valid JSON response when process topic route queries rocketmq#4432 change route info to standard json such as:
      {"brokerDatas":[{"brokerAddrs":{"0":"127.0.0.1:10911"}}
      the old is:
      {"brokerDatas":[{"brokerAddrs":{0:"127.0.0.1:10911"}}

  2. Please tell us about your environment:

    • What is your OS?

    • What is your client version?

    • What is your RocketMQ version?

  3. Other information (e.g. detailed explanation, logs, related issues, suggestions on how to fix, etc):

FEATURE REQUEST

  1. Please describe the feature you are requesting.

  2. Provide any additional detail on your proposed use case for this feature.

  3. Indicate the importance of this issue to you (blocker, must-have, should-have, nice-to-have). Are you currently using any workarounds to address this issue?

  4. If there are some sub-tasks using -[] for each subtask and create a corresponding issue to map to the sub task:

@yuz10 yuz10 linked a pull request Jun 16, 2022 that will close this issue
5 tasks
@duhenglucky
Copy link
Contributor

@yuz10 It seems we'd better submit a PR to temporarily change it back to the previous way to ensure the compatibility of the old client. Compatibility is the first

@ShannonDing ShannonDing added the discuss Something undering disscussing label Jul 21, 2022
ShannonDing pushed a commit that referenced this issue Aug 23, 2022
[ISSUE #845] support standard json
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discuss Something undering disscussing
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants