Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Interceptor for producer and consumer. #86

Closed
xujianhai666 opened this issue Jul 3, 2019 · 0 comments
Closed

Add Interceptor for producer and consumer. #86

xujianhai666 opened this issue Jul 3, 2019 · 0 comments

Comments

@xujianhai666
Copy link
Member

FEATURE REQUEST

  1. Add Interceptor for producer and consumer.

  2. Provide any additional detail on your proposed use case for this feature.
    Sometimes, we want print log、add metrics or timeout check when we send message or consumer messages. But it is ugly to add function around the inner method, and it is not
    necessary demand, so it is a good to add interceptor to decoupling the user custom logic from the inner impl.

  3. Indicate the importance of this issue to you (blocker, must-have, should-have, nice-to-have).
    should-have

  4. If there are some sub-tasks using -[] for each subtask and create a corresponding issue to map to the sub task:

xujianhai666 added a commit to xujianhai666/rocketmq-client-go that referenced this issue Jul 3, 2019
@wenfengwang wenfengwang mentioned this issue Jul 4, 2019
20 tasks
zongtanghu pushed a commit that referenced this issue Jul 6, 2019
* add interceptor

* add log

* add producer example

* refactor code according to new version

* refactor code according to new version

* add example

* fix nil bug

* delete extra code

* delete test code

* add comment. resolves #86

* rename

* rename

* stash

* stash

* fix  bug

* stash

* refactor consumer interceptor

* add example

* add example

* 重构interceptor

* fix typo

* add ctx key

* remove extra code

* add ctx to conusme

* refactor consumer interceptor

* refactor consumer interceptor

* refactor consumer interceptor

* lower case chainInterceptor

* rename println
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant