Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lack of setting new value for pullThresholdSizeForTopic after size was calc. #861

Closed
ShannonDing opened this issue Jul 21, 2022 · 0 comments · Fixed by #814
Closed

lack of setting new value for pullThresholdSizeForTopic after size was calc. #861

ShannonDing opened this issue Jul 21, 2022 · 0 comments · Fixed by #814
Labels
bug Something isn't working
Milestone

Comments

@ShannonDing
Copy link
Member

after rebalance, PullThresholdSizeForTopic is not set to new value.

if count > 0 {
		if pc.option.PullThresholdForTopic != -1 {
			newVal := pc.option.PullThresholdForTopic / count
			if newVal == 0 {
				newVal = 1
			}
			rlog.Info("The PullThresholdForTopic is changed", map[string]interface{}{
				rlog.LogKeyValueChangedFrom: pc.option.PullThresholdForTopic,
				rlog.LogKeyValueChangedTo:   newVal,
			})
			pc.option.PullThresholdForTopic = newVal
		}

		if pc.option.PullThresholdSizeForTopic != -1 {
			newVal := pc.option.PullThresholdSizeForTopic / count
			if newVal == 0 {
				newVal = 1
			}
			rlog.Info("The PullThresholdSizeForTopic is changed", map[string]interface{}{
				rlog.LogKeyValueChangedFrom: pc.option.PullThresholdSizeForTopic,
				rlog.LogKeyValueChangedTo:   newVal,
			})
		}
	}
@ShannonDing ShannonDing added the bug Something isn't working label Jul 21, 2022
@ShannonDing ShannonDing added this to the 2.1.1 milestone Jul 21, 2022
@ShannonDing ShannonDing linked a pull request Jul 21, 2022 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant