Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix pullThresholdSizeForTopic invalid #814

Merged
merged 3 commits into from
Jul 21, 2022
Merged

fix pullThresholdSizeForTopic invalid #814

merged 3 commits into from
Jul 21, 2022

Conversation

hjxp
Copy link
Contributor

@hjxp hjxp commented Apr 18, 2022

fix pullThresholdSizeForTopic invalid

ShannonDing
ShannonDing reviewed Jul 21, 2022
View reviewed changes
consumer/consumer.go Outdated Show resolved Hide resolved
@ShannonDing ShannonDing linked an issue Jul 21, 2022 that may be closed by this pull request
lack of setting new value for pullThresholdSizeForTopic after size was calc. #861
Closed
ShannonDing
ShannonDing approved these changes Jul 21, 2022
View reviewed changes
Copy link
Member

@ShannonDing ShannonDing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ShannonDing ShannonDing merged commit d802a4d into apache:master Jul 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ShannonDing ShannonDing ShannonDing approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

lack of setting new value for pullThresholdSizeForTopic after size was calc.
2 participants
@hjxp @ShannonDing