Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #1018] Fix unintended shutdown of shared rmqClient #1019

Merged
merged 1 commit into from
Apr 28, 2023

Conversation

wgdzlh
Copy link
Contributor

@wgdzlh wgdzlh commented Mar 31, 2023

caused by missing ref count

What is the purpose of the change

fix #1018

Brief changelog

revert #888

Verifying this change

XXXX

Follow this checklist to help us incorporate your contribution quickly and easily. Notice, it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR.

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when a cross-module dependency exists.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

caused by missing ref count
@cserwen cserwen added this to the 2.1.2 milestone Apr 27, 2023
@cserwen
Copy link
Member

cserwen commented Apr 28, 2023

Good catch!

@cserwen cserwen merged commit 8ea107c into apache:master Apr 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Faulty move of reference count of shared rmqClient
2 participants