Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #101] Add QueueSelector in producer #102

Merged
merged 4 commits into from
Jul 9, 2019

Conversation

xujianhai666
Copy link
Member

What is the purpose of the change

Add QueueSelector in producer

Brief changelog

add QueueSelector in ProducerOptions
add RoundRobinQueueSelector in default ProducerOptions
replace selector with QueueSelector

Verifying this change

RoundRobinQueueSelector unit test
add custom manualQueueSelector in example/producer/async

@ShannonDing
Copy link
Member

@xujianhai666 Could you please fix the conflicting files?

@xujianhai666
Copy link
Member Author

@xujianhai666 Could you please fix the conflicting files?

@ShannonDing done

internal/producer/producer.go Show resolved Hide resolved
primitive/message.go Outdated Show resolved Hide resolved
@wenfengwang
Copy link
Member

LGTM, @ShannonDing @zongtanghu @jonnxu please merge the PR

@jonnxu
Copy link
Contributor

jonnxu commented Jul 9, 2019

LGTM

@jonnxu jonnxu added the enhancement New feature or request label Jul 9, 2019
@jonnxu jonnxu merged commit 136d792 into apache:native Jul 9, 2019
@xujianhai666 xujianhai666 deleted the feat-msgselector branch July 9, 2019 05:18
@wenfengwang wenfengwang mentioned this pull request Jul 9, 2019
20 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants