change ConsumeGoroutineNums max value allowed #1049
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ConsumeGoroutineNums should allow large values to be set, detail see apache#883 (comment)
5 tasks
ShannonDing
approved these changes
May 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The newly added parameter ConsumeGoroutineNums should allow to achieve the effect of not limiting the number of go routines as before.
The maximum number of 1000 is relatively small. If the performance of the machine is better, it may affect the maximum capacity of consumption.
rocketmq-client-go/consumer/push_consumer.go
ConsumeGoroutineNums should allow large values to be set, detail see
#883 (comment)