Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix WithRecover 无法recover问题 #1074

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

snail-plus
Copy link

@snail-plus snail-plus commented Jul 4, 2023

What is the purpose of the change

fix WithRecover 无法recover

Brief changelog

add PanicHandler handle error

Verifying this change

XXXX

Follow this checklist to help us incorporate your contribution quickly and easily. Notice, it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR.

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when a cross-module dependency exists.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

@cserwen
Copy link
Member

cserwen commented Jul 13, 2023

@snail-plus Maybe it would be better to have a simple unit test.

@snail-plus
Copy link
Author

@snail-plus Maybe it would be better to have a simple unit test.

ok , I will add a simple unit test later.

@twz915
Copy link
Contributor

twz915 commented Dec 4, 2023

Previously, users could reassign the PanicHandler to their own handler, but now they can’t do it.
such as

// 设置recover
primitive.PanicHandler = func(i interface{}) {
    msentry.CaptureMessage(fmt.Sprintf("%+v", i), nil)
}

Please keep the code compatible, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants