Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ignore name server connection read timeout log #1117

Merged
merged 3 commits into from
Dec 6, 2023

Conversation

twz915
Copy link
Contributor

@twz915 twz915 commented Dec 5, 2023

What is the purpose of the change

if err != nil {
// conn has been closed actively
if r.isClosed(err) {
return
}
if err != io.EOF {
rlog.Error("conn error, close connection", map[string]interface{}{
rlog.LogKeyUnderlayError: err,
})
}
c.closeConnection(r)
r.destroy()
break
}
err = r.Conn.SetReadDeadline(time.Now().Add(c.config.ReadTimeout))
if err != nil {
continue
}

the error logs

2023-12-05T10:33:03+08:00 ERROR remote/remote_client.go:183 github.com/apache/rocketmq-client-go/v2/internal/remote.(*remotingClient).receiveResponse conn error, close connection {"underlayError": "read tcp 192.7.128.158:43358->192.183.1.196:9876: i/o timeout"}

when get route info from name server timeout, just ignore the error log

Brief changelog

ignore conn read timeout log

Copy link

@jjeffcaii jjeffcaii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@twz915 twz915 changed the title fix: ignore conn read timeout fix: ignore name server connection read timeout log Dec 6, 2023
Copy link

@jjeffcaii jjeffcaii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ShannonDing ShannonDing merged commit 5af5d6d into apache:master Dec 6, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants