Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #176]add ctx to rmqClient & remoteClient #177

Merged
merged 1 commit into from
Aug 26, 2019

Conversation

xujianhai666
Copy link
Member

@xujianhai666 xujianhai666 commented Aug 25, 2019

What is the purpose of the change

[ISSUE #176 ]Support ctx of rmqClient and remoteClient

Brief changelog

Verifying this change

@codecov-io
Copy link

Codecov Report

Merging #177 into native will increase coverage by 0.53%.
The diff coverage is 33.87%.

Impacted file tree graph

@@            Coverage Diff             @@
##           native     #177      +/-   ##
==========================================
+ Coverage   24.44%   24.98%   +0.53%     
==========================================
  Files          45       45              
  Lines        4635     4583      -52     
==========================================
+ Hits         1133     1145      +12     
+ Misses       3351     3289      -62     
+ Partials      151      149       -2
Impacted Files Coverage Δ
internal/mock_client.go 0% <0%> (ø) ⬆️
internal/trace.go 32.9% <0%> (ø) ⬆️
internal/remote/mock_remote_client.go 0% <0%> (ø) ⬆️
consumer/push_consumer.go 15.66% <0%> (ø) ⬆️
internal/client.go 0.29% <0%> (ø) ⬆️
consumer/consumer.go 3.86% <0%> (ø) ⬆️
internal/remote/future.go 100% <100%> (ø) ⬆️
internal/remote/remote_client.go 52.48% <100%> (+0.33%) ⬆️
internal/route.go 5.1% <100%> (ø) ⬆️
consumer/offset_store.go 68.06% <50%> (ø) ⬆️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1ee23b7...084feee. Read the comment docs.

@wenfengwang
Copy link
Member

LGTM

@zongtanghu zongtanghu merged commit a1b4211 into apache:native Aug 26, 2019
@ShannonDing ShannonDing added this to the Native-2.0.0-alpha3 milestone Aug 26, 2019
@ShannonDing ShannonDing added the enhancement New feature or request label Aug 26, 2019
@wenfengwang wenfengwang mentioned this pull request Aug 26, 2019
26 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants