Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support nameserver resolver #457

Merged
merged 12 commits into from
Apr 26, 2020

Conversation

xujianhai666
Copy link
Member

use nameserver resolver instead of nameserver addr, we can pass
passThrough for direct addr, httpResolver for domain, envResovler
for env param.

Closes #455

@ShannonDing
Copy link
Member

IMO, it is better to add a new nameserver resolver, but for old users, it is better to keep the "WithNameServer" at the same time and do create a default resolver inner for it.

@ShannonDing ShannonDing added the discuss Something undering disscussing label Mar 25, 2020
@xujianhai666
Copy link
Member Author

IMO, it is better to add a new nameserver resolver, but for old users, it is better to keep the "WithNameServer" at the same time and do create a default resolver inner for it.

ok, I impl later

use nameserver resolver instead of nameserver addr, we can pass
passThrough for direct addr, httpResolver for domain, envResovler
for env param.

Closes apache#455
@xujianhai666
Copy link
Member Author

IMO, it is better to add a new nameserver resolver, but for old users, it is better to keep the "WithNameServer" at the same time and do create a default resolver inner for it.

done

primitive/nsresolver.go Show resolved Hide resolved
primitive/nsresolver_test.go Show resolved Hide resolved
@codecov-io
Copy link

codecov-io commented Apr 26, 2020

Codecov Report

Merging #457 into native will increase coverage by 0.08%.
The diff coverage is 49.16%.

Impacted file tree graph

@@            Coverage Diff             @@
##           native     #457      +/-   ##
==========================================
+ Coverage   24.72%   24.80%   +0.08%     
==========================================
  Files          48       49       +1     
  Lines        5570     5716     +146     
==========================================
+ Hits         1377     1418      +41     
- Misses       4003     4095      +92     
- Partials      190      203      +13     
Impacted Files Coverage Δ
consumer/consumer.go 16.31% <ø> (+0.05%) ⬆️
consumer/mock_offset_store.go 50.00% <ø> (ø)
consumer/offset_store.go 66.50% <ø> (+1.83%) ⬆️
consumer/pull_consumer.go 0.00% <0.00%> (ø)
internal/client.go 0.22% <0.00%> (-0.01%) ⬇️
internal/mock_namesrv.go 0.00% <0.00%> (ø)
internal/model.go 46.73% <ø> (ø)
internal/remote/codec.go 60.08% <ø> (ø)
internal/remote/mock_remote_client.go 0.00% <ø> (ø)
internal/trace.go 27.71% <ø> (-2.33%) ⬇️
... and 14 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1ce9fd9...655be62. Read the comment docs.

@ShannonDing ShannonDing added the enhancement New feature or request label Apr 26, 2020
@ShannonDing ShannonDing added this to the 2.1.0 milestone Apr 26, 2020
@ShannonDing ShannonDing merged commit 17a373f into apache:native Apr 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discuss Something undering disscussing enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants