-
Notifications
You must be signed in to change notification settings - Fork 409
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support nameserver resolver #457
Conversation
IMO, it is better to add a new nameserver resolver, but for old users, it is better to keep the "WithNameServer" at the same time and do create a default resolver inner for it. |
ok, I impl later |
use nameserver resolver instead of nameserver addr, we can pass passThrough for direct addr, httpResolver for domain, envResovler for env param. Closes apache#455
9f442e3
to
2a4f9df
Compare
done |
Change to src dir to do go fmt and go test
Codecov Report
@@ Coverage Diff @@
## native #457 +/- ##
==========================================
+ Coverage 24.72% 24.80% +0.08%
==========================================
Files 48 49 +1
Lines 5570 5716 +146
==========================================
+ Hits 1377 1418 +41
- Misses 4003 4095 +92
- Partials 190 203 +13
Continue to review full report at Codecov.
|
use nameserver resolver instead of nameserver addr, we can pass
passThrough for direct addr, httpResolver for domain, envResovler
for env param.
Closes #455