Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #473] support nsresolver in TraceConfig #474

Merged
merged 1 commit into from
Apr 27, 2020

Conversation

dbl-x
Copy link
Contributor

@dbl-x dbl-x commented Apr 27, 2020

What is the purpose of the change

support ns-resolver config in TraceConfig

close #473

@ShannonDing
Copy link
Member

it is better to add a new nameserver resolver for trace config, but for old users, it is better to keep the "WithNameServer" at the same time and do create a default resolver inner for it.

@ShannonDing ShannonDing added the enhancement New feature or request label Apr 27, 2020
@codecov-io
Copy link

codecov-io commented Apr 27, 2020

Codecov Report

Merging #474 into master will decrease coverage by 0.03%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #474      +/-   ##
==========================================
- Coverage   24.80%   24.77%   -0.04%     
==========================================
  Files          49       49              
  Lines        5716     5723       +7     
==========================================
  Hits         1418     1418              
- Misses       4095     4102       +7     
  Partials      203      203              
Impacted Files Coverage Δ
internal/trace.go 27.05% <0.00%> (-0.67%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ba76ac6...3ea8d3f. Read the comment docs.

@dbl-x
Copy link
Contributor Author

dbl-x commented Apr 27, 2020

it is better to add a new nameserver resolver for trace config, but for old users, it is better to keep the "WithNameServer" at the same time and do create a default resolver inner for it.

Great suggestion, already done this

@ShannonDing ShannonDing added this to the 2.1.0 milestone Apr 27, 2020
@ShannonDing ShannonDing changed the title support nsresolver in TraceConfig [ISSUE #473] support nsresolver in TraceConfig Apr 27, 2020
@ShannonDing ShannonDing merged commit ef5bda6 into apache:master Apr 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Master]un-support using nsresolver to configure TraceConfig's name server
3 participants