Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(reconsume): subMsgs should be used instead of msgs in consume goroutine #504

Merged
merged 6 commits into from
Jul 8, 2020

Conversation

hzjiangjian
Copy link
Contributor

What is the purpose of the change

To fix bug when message that consumed failed send back.

Brief changelog

Variable "subMsgs" should be used instead of "msgs" in consume goroutine. In which case when one single message consume failed, all messages of this batch will be send back. Especially, if more than one message consume failed in different goroutine, all messages of this batch will be send back more than one time.

Verifying this change

Follow this checklist to help us incorporate your contribution quickly and easily. Notice, it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR.

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when a cross-module dependency exists.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

@hzjiangjian hzjiangjian changed the title Jj dev fix(reconsume): subMsgs should be used instead of msgs in consume goroutine Jul 2, 2020
@ShannonDing ShannonDing merged commit 80b3acc into apache:master Jul 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants