Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/resolver #552

Merged
merged 3 commits into from
Dec 3, 2020
Merged

Feat/resolver #552

merged 3 commits into from
Dec 3, 2020

Conversation

vearne
Copy link
Contributor

@vearne vearne commented Nov 6, 2020

What is the purpose of the change

In my scenario, my nameservers are hosts represented by a group of domain names. So I need a new resolver to resolve the nameservers.

Brief changelog

add dns Resolver to resolve name server

Verifying this change

go test . -v --run TestDNSResolver

@xujianhai666
Copy link
Member

fmt before pr agian. @vearne

@codecov-io
Copy link

codecov-io commented Nov 27, 2020

Codecov Report

Merging #552 (8208f59) into master (e1d9be8) will increase coverage by 0.12%.
The diff coverage is 60.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #552      +/-   ##
==========================================
+ Coverage   24.21%   24.33%   +0.12%     
==========================================
  Files          48       48              
  Lines        5010     5026      +16     
==========================================
+ Hits         1213     1223      +10     
- Misses       3598     3602       +4     
- Partials      199      201       +2     
Impacted Files Coverage Δ
primitive/nsresolver.go 55.14% <60.00%> (+0.79%) ⬆️
consumer/push_consumer.go 11.46% <0.00%> (+0.12%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e1d9be8...8208f59. Read the comment docs.

@vearne
Copy link
Contributor Author

vearne commented Nov 27, 2020 via email

@xujianhai666 xujianhai666 merged commit 9d25770 into apache:master Dec 3, 2020
@xujianhai666
Copy link
Member

sorry for that I merge incorrectly, could pull request again with format "https://github.com/apache/rocketmq/wiki/RIP-14-RocketMQ-Community-Operation-Conventions"

@vearne
Copy link
Contributor Author

vearne commented Dec 3, 2020

sorry for that I merge incorrectly, could pull request again with format "https://github.com/apache/rocketmq/wiki/RIP-14-RocketMQ-Community-Operation-Conventions"

Is something wrong in my comment?

@vearne
Copy link
Contributor Author

vearne commented Dec 4, 2020

@xujianhai666 Is something wrong in my comment?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants