Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow further subscription even after client starts, to align with Java SDK's behavior #560

Merged
merged 1 commit into from
Nov 26, 2020

Conversation

beiwei30
Copy link
Member

What is the purpose of the change

allow further subscription even after client starts, to align with Java SDK's behavior

Brief changelog

Verifying this change

XXXX

Follow this checklist to help us incorporate your contribution quickly and easily. Notice, it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR.

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when a cross-module dependency exists.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

@codecov-io
Copy link

codecov-io commented Nov 24, 2020

Codecov Report

Merging #560 (f554daf) into master (e1d9be8) will increase coverage by 0.01%.
The diff coverage is 33.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #560      +/-   ##
==========================================
+ Coverage   24.21%   24.22%   +0.01%     
==========================================
  Files          48       48              
  Lines        5010     5011       +1     
==========================================
+ Hits         1213     1214       +1     
  Misses       3598     3598              
  Partials      199      199              
Impacted Files Coverage Δ
consumer/push_consumer.go 11.46% <33.33%> (+0.12%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e1d9be8...f554daf. Read the comment docs.

@xujianhai666
Copy link
Member

lgtm

@xujianhai666 xujianhai666 merged commit 9d9e413 into apache:master Nov 26, 2020
@ShannonDing ShannonDing added the enhancement New feature or request label Nov 26, 2020
@beiwei30
Copy link
Member Author

beiwei30 commented Dec 1, 2020

thanks :)

@beiwei30 beiwei30 deleted the subscribe-after-start branch December 1, 2020 02:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants