Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update nsresolver.go #567

Merged
merged 2 commits into from
Jan 15, 2021
Merged

Update nsresolver.go #567

merged 2 commits into from
Jan 15, 2021

Conversation

twz915
Copy link
Contributor

@twz915 twz915 commented Dec 11, 2020 •
edited
Loading

fix http 5xx srvs error

What is the purpose of the change

err logs

namesrv="<!DOCTYPE HTML PUBLIC...."

time="2020-12-07T19:33:28+08:00" level=error msg="connect to namesrv failed." namesrv="<!DOCTYPE HTML PUBLIC \"-//IETF//DTD HTML 2.0//EN\">\r\n<html>\r\n<head><title>502 Bad Gateway</title></head>\r\n<body bgcolor=\"white\">\r\n<h1>502 Bad Gateway</h1>\r\n<p>Theproxy server received an invalid response from an upstream server. Sorry for the inconvenience.<br/>\r\nPlease report this message and include the following information to us.<br/>\r\nThank you very much!</p>\r\n<table>\r\n<tr>\r\n<td>URL:</td>\r\n<td>http://jmenv.tbsite.net:8080/rocketmq/nsaddr</td>\r\n</tr>\r\n<tr>\r\n<td>\r\n</tr>\r\n<tr>\r\n<td>Date:</td>\r\n<td>2020/12/07 18:01:28</td>\r\n</tr>\r\n</table>\r\n<hr/>Powered by Tengine</body>\r\n</html>\r\n" topic="%RETRY%your-topic"

Brief changelog

update or set srvs only http 200 ok

@twz915
Update nsresolver.go
88dde91 
fix http 5xx srvs error
@ShannonDing
Copy link
Member

hi, some test cases failed.

@codecov-io
Copy link

codecov-io commented Jan 7, 2021 •
edited
Loading

Codecov Report

Merging #567 (be19831) into master (4c35ae2) will decrease coverage by 0.00%.
The diff coverage is 60.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #567      +/-   ##
==========================================
- Coverage   24.22%   24.21%   -0.01%     
==========================================
  Files          48       48              
  Lines        5011     5013       +2     
==========================================
  Hits         1214     1214              
- Misses       3598     3599       +1     
- Partials      199      200       +1
Impacted Files Coverage Δ
primitive/nsresolver.go 53.19% <60.00%> (-1.16%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4c35ae2...be19831. Read the comment docs.

@twz915
Copy link
Contributor Author

twz915 commented Jan 7, 2021

hi, some test cases failed.

All checks have passed

@ShannonDing ShannonDing merged commit f9005db into apache:master Jan 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ShannonDing ShannonDing ShannonDing approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@twz915 @ShannonDing @codecov-io