Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #631] Support Consuming from Slave #632

Merged
merged 1 commit into from
Jul 1, 2021

Conversation

maixiaohai
Copy link
Contributor

What is the purpose of the change

issue #631

Brief changelog

  1. Add slave node id retry
  2. Add unit test

Verifying this change

XXXX

Follow this checklist to help us incorporate your contribution quickly and easily. Notice, it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR.

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when a cross-module dependency exists.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

@codecov-io
Copy link

codecov-io commented Mar 24, 2021

Codecov Report

Merging #632 (38ec9fb) into master (d6e66a2) will increase coverage by 0.52%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #632      +/-   ##
==========================================
+ Coverage   24.42%   24.95%   +0.52%     
==========================================
  Files          48       48              
  Lines        5207     5226      +19     
==========================================
+ Hits         1272     1304      +32     
+ Misses       3725     3710      -15     
- Partials      210      212       +2     
Impacted Files Coverage Δ
internal/route.go 18.97% <100.00%> (+9.72%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d6e66a2...38ec9fb. Read the comment docs.

@maixiaohai maixiaohai added the wip label May 25, 2021
@wenfengwang wenfengwang removed the wip label Jul 1, 2021
@wenfengwang wenfengwang changed the title [ISSUE #631] Consumer can't consume message When cluster deployed on DLedger mode and enable slave read [ISSUE #631] Support Consuming from Slave Jul 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants