Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #614] Fix go routine leaks when consumer close with msg channel blocked #642

Merged
merged 1 commit into from
Jun 17, 2021

Conversation

maixiaohai
Copy link
Contributor

What is the purpose of the change

issue #614

Brief changelog

1 close msg channel when consumer closed with RWMutex
2 check if process queue is dropped before write to msg channel

Verifying this change

XXXX

Follow this checklist to help us incorporate your contribution quickly and easily. Notice, it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR.

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when a cross-module dependency exists.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

@maixiaohai maixiaohai added the wip label May 19, 2021
@maixiaohai maixiaohai merged commit c688c19 into apache:master Jun 17, 2021
@maixiaohai maixiaohai linked an issue Jun 17, 2021 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Master] Goroutine leaks when consumer restart frequently
2 participants