Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #650] fix: correctly mark messages to be reconsumed #693

Merged
merged 1 commit into from Nov 28, 2021

Conversation

luyui
Copy link
Contributor

@luyui luyui commented Jul 1, 2021

What is the purpose of the change

Relates to PULL #619
fixes #650 #618

Brief changelog

When SuspendCurrentQueueAMoment is returned for orderly consumption, makeMessageToCosumeAgain should be used instead of putMessages, just like the java counterpart.

Verifying this change

None

@codecov-commenter
Copy link

Codecov Report

Merging #693 (f410c92) into master (c688c19) will not change coverage.
The diff coverage is 0.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #693   +/-   ##
=======================================
  Coverage   24.71%   24.71%           
=======================================
  Files          48       48           
  Lines        5223     5223           
=======================================
  Hits         1291     1291           
  Misses       3726     3726           
  Partials      206      206           
Impacted Files Coverage Δ
consumer/push_consumer.go 11.84% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c688c19...f410c92. Read the comment docs.

@rhinogo
Copy link

rhinogo commented Nov 28, 2021

这个修改怎么在master看不到

@maixiaohai
Copy link
Contributor

这个修改怎么在master看不到

还没有merge

@maixiaohai maixiaohai merged commit a8f01df into apache:master Nov 28, 2021
@vongosling vongosling added this to the 2.2.0 milestone Nov 29, 2021
@vongosling
Copy link
Member

@maixiaohai We should mark the milestone

@maixiaohai
Copy link
Contributor

@maixiaohai We should mark the milestone

copy~ Thanks for your reminder~

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Orderly Consumer will not reconsume the message
7 participants