Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #710] Fix send duplicate message in trace interceptor #709

Merged
merged 1 commit into from
Aug 12, 2021

Conversation

yuz10
Copy link
Member

@yuz10 yuz10 commented Aug 11, 2021

What is the purpose of the change

#710 in trace interceptor, if TraceTopicName equals current message topic then message will be send twice

Brief changelog

XX

Verifying this change

XXXX

Follow this checklist to help us incorporate your contribution quickly and easily. Notice, it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR.

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when a cross-module dependency exists.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

@codecov-commenter
Copy link

codecov-commenter commented Aug 11, 2021

Codecov Report

Merging #709 (4a57014) into master (46701f1) will not change coverage.
The diff coverage is 0.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #709   +/-   ##
=======================================
  Coverage   25.70%   25.70%           
=======================================
  Files          49       49           
  Lines        6123     6123           
=======================================
  Hits         1574     1574           
  Misses       4335     4335           
  Partials      214      214           
Impacted Files Coverage Δ
producer/interceptor.go 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 46701f1...4a57014. Read the comment docs.

@yuz10 yuz10 changed the title Fix send duplicate message in trace interceptor [ISSUE #710] Fix send duplicate message in trace interceptor Aug 11, 2021
@yuz10 yuz10 merged commit 077cd3b into apache:master Aug 12, 2021
@vongosling vongosling linked an issue Aug 12, 2021 that may be closed by this pull request
@yuz10 yuz10 deleted the patch-1 branch September 3, 2021 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Master] message will be send twice in trace interceptor
3 participants