New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix long time block when remote endpoint crash. #816
fix long time block when remote endpoint crash. #816
Conversation
…et ops when remote endpoint crash. 2. enable tcp keep alive.
just add common use case of golang net programming see https://github.com/gorilla/websocket/pull/763/files and sarama kafka go cient. https://github.com/Shopify/sarama/blob/9904b379913b586cb1b9f77f63a3d0c8e5f9932a/broker.go#L879-L897 |
2. change default read/write Deadline to 120 sec. 3. close connection when set deadline fail.
@guyinyou @Git-Yang @maixiaohai can you take a look? |
look good to me 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@ShannonDing @cserwen @xujianhai666 can you take a look? |
fix #817
add tcp conn write and read deadline to avoid long time block socket ops when remote endpoint crash.
enable tcp keep alive.
remove request from responseTable when InvokeAsync.
doRequest close socket connection with destory call.