Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #832] Client may submit wrong offset when network instability #833

Merged
merged 1 commit into from
Jun 14, 2022

Conversation

aaronwang95
Copy link
Contributor

@aaronwang95 aaronwang95 commented May 31, 2022

What is the purpose of the change

fix #832
To expose the error thrown when client failed to get offset from broker

Brief changelog

  • add readWithException to OffsetStore and deprecate read
  • add computePullFromWhereWithException to defaultConsumer and deprecate computePullFromWhere
  • test files to use new methods

Verifying this change

  • add a 60s sleeping time to broker's ConsumerOffsetManager.queryOffset function, start this broker
  • start consumer and check if the consumer's offset is set to minLogicOffset

Follow this checklist to help us incorporate your contribution quickly and easily. Notice, it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR.

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when a cross-module dependency exists.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

@ShannonDing ShannonDing linked an issue Jun 14, 2022 that may be closed by this pull request
@ShannonDing ShannonDing added the bug Something isn't working label Jun 14, 2022
@ShannonDing ShannonDing merged commit 16443e2 into apache:master Jun 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Client may submit wrong offset when network instability
2 participants