Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #876] Safely checking context in trace producer. #863

Merged
merged 3 commits into from
Jul 31, 2022

Conversation

aireet
Copy link
Contributor

@aireet aireet commented Jul 22, 2022

What is the purpose of the change

when i use interceptor for build my apm, i got panic in async producer, so I think it can be safely

close #876

Brief changelog

XX

Verifying this change

XXXX

Follow this checklist to help us incorporate your contribution quickly and easily. Notice, it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR.

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when a cross-module dependency exists.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

@ShannonDing ShannonDing added this to the 2.2.0 milestone Jul 25, 2022
@codecov-commenter
Copy link

codecov-commenter commented Jul 26, 2022

Codecov Report

Merging #863 (f8c1bbd) into master (129701a) will increase coverage by 0.01%.
The diff coverage is 30.76%.

@@            Coverage Diff             @@
##           master     #863      +/-   ##
==========================================
+ Coverage   25.00%   25.01%   +0.01%     
==========================================
  Files          51       51              
  Lines        6632     6640       +8     
==========================================
+ Hits         1658     1661       +3     
- Misses       4750     4755       +5     
  Partials      224      224              
Impacted Files Coverage Δ
primitive/ctx.go 0.00% <0.00%> (ø)
producer/interceptor.go 0.00% <0.00%> (ø)
producer/producer.go 28.35% <57.14%> (+0.35%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us.

@ShannonDing ShannonDing added the enhancement New feature or request label Jul 30, 2022
@ShannonDing ShannonDing changed the title [feat] /safely producer ctx [ISSUE #876] Safely checking context in trace producer. Jul 30, 2022
Copy link
Member

@ShannonDing ShannonDing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ShannonDing ShannonDing merged commit 6c2f270 into apache:master Jul 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Safely checking context in trace producer.
4 participants