Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feat] fix query not found #886

Merged
merged 1 commit into from
Aug 7, 2022

Conversation

aireet
Copy link
Contributor

@aireet aireet commented Aug 5, 2022

What is the purpose of the change

when i start a new group to consume an old topic

i got some error logs

"[RocketMQ] msg: fetch offset of mq from broker error \n fields: map[MessageQueue:MessageQueue [topic=demo-topic, brokerName=broker-master, queueId=2] consumerGroup:rocketmq-EE10 underlayError:broker response code: 22, remarks: Not found, V3_0_6_SNAPSHOT maybe this group consumer boot first]"

"[RocketMQ] msg: do defaultConsumer, add a new mq failed \n fields: map[MessageQueue:MessageQueue [topic=demo-topic, brokerName=broker-master, queueId=2] consumerGroup:rocketmq-EE10]"}

then i find
https://github.com/apache/rocketmq-client-go/blob/master/consumer/consumer.go:770

	lastOffset, err := dc.storage.readWithException(mq, _ReadFromStore)
	if err != nil {
		// 这里 lastOffset = -1
		return lastOffset, err
	}

if the broker query not found, program get an error, that will triggers this problem, and dc.option.FromWhere will never work

Brief changelog

XX

Verifying this change

XXXX

Follow this checklist to help us incorporate your contribution quickly and easily. Notice, it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR.

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when a cross-module dependency exists.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

@ShannonDing ShannonDing added the enhancement New feature or request label Aug 7, 2022
@ShannonDing ShannonDing added this to the 2.2.0 milestone Aug 7, 2022
@ShannonDing ShannonDing merged commit ffd7241 into apache:master Aug 7, 2022
@Cczzzz
Copy link

Cczzzz commented Sep 26, 2022

When will this feature be released?

@GrumpyCat0413
Copy link

I have the same problem,how to solve it?

@GrumpyCat0413
Copy link

you can update sdk version github.com/apache/rocketmq-client-go/v2 to upper >2.1.1

@ngyhd
Copy link

ngyhd commented Dec 27, 2022

you can update sdk version github.com/apache/rocketmq-client-go/v2 to upper >2.1.1

这个问题修复在2.2.0

@adamzhoul
Copy link

when will 2.2.0 plan to release?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
6 participants